[REQUEST] Support for xrptoolkit.com

korntnieu · May 23, 2023, 8:08am

Hi,

New Trezor user here. I would like to request support for using Trezor with XRP toolkit (xrptoolkit.com).

This is important to perform transactions within XRPL blockchain (e.g. create/buy/sell/etc. tokens within XRPL).

There was a PR submitted previously but was closed & not materialized.

Add full XRP support by patriksletmo · Pull Request #848 · trezor/trezor-firmware · GitHub

github.com/trezor/trezor-firmware

Add full XRP support

trezor:ripple-full ← TowoLabs:ripple-full-old-messages

opened 12:50PM - 13 Feb 20 UTC

patriksletmo

+5471 -249

# Summary This pull request adds support for all 18 XRP Ledger transaction type…s and all common fields. With new use-cases in web monetization, gaming and decentralized finance being built on top of the XRP Ledger, hardware wallet support for its more advanced features such as escrows, cross-currency payments and decentralized exchange orders are needed to maintain security and avoid stiffling innovation. In short, we have: - Maintained full backwards compatibility - Re-written the serializer to support all [types](https://xrpl.org/serialization.html#type-list) present in transaction fields - Implemented support for displaying all transaction fields - Implemented support for displaying fields like flags and timestamps in a human-readable format - Implemented support for reading the public key - Implemented support for multi-signing - Please see the updated [README](https://github.com/TowoLabs/trezor-firmware/blob/ripple-full-old-messages/core/src/apps/ripple/README.md) for additional details. # Testing We have added unit tests in the `core/tests` directory and device integration tests in the `tests/device_tests` directory.

Please reconsider adding support for this.

Thank you.