Issue with signing contract using OpenSea and Metamask

zapla · February 21, 2022, 12:31pm

Since OpenSea has rolled out new contract that requires support of EIP712:

It is currently not possible to sign such contract using Trezor connected to Metamask as this standard is not fully supported on MetaMask side.

You can follow the progress in following PR:

github.com/MetaMask/metamask-extension

Add EIP-712 support for Trezor

MetaMask:develop ← MetaMask:trezor-eip-712-forked

opened 10:01PM - 20 Feb 22 UTC

danjm

+140 -290

**Pushing the branch of https://github.com/MetaMask/metamask-extension/pull/1335…8 directly into the repo so that the MetaMask can move this forward over the next 24 hours.** ---- Description on the original PR (by @aloisklink): Fixes: #11498 **Blocked by**: - [ ] Merge and release of https://github.com/MetaMask/eth-trezor-keyring/pull/117 - [ ] Bumping `eth-trezor-keyring`'s version in `package.json` Add EIP-712 `signTypedData_v4` support for Trezor. Thanks to @alisinabh, @matejcik, and @BrandonNoad for their help getting Trezor Model 1 supported too in https://github.com/MetaMask/eth-trezor-keyring/pull/117, I've stuck you guys as co-authors in the git commit, let me know if you want me to remove you :wink: ### Manual testing steps: - Go to https://metamask.github.io/test-dapp/ - Click on "Sign" and "Verify" for `signTypedData_v4` using: - A Trezor Model T hardware wallet - A Trezor Model 1 hardware wallet

zapla · February 21, 2022, 12:31pm

zapla · February 22, 2022, 10:53am

zapla · February 23, 2022, 3:05pm